invisi/angular.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Wiki Activity

fixup! fix(ngAria.ngClick): restrict preventDefault on space / enter to non-interactive elements

Browse Source
This commit is contained in:
Martin Staffa
2018-09-03 09:32:08 +02:00
parent 4be80aefa2
commit 190bc1d52b
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/ngAria/ariaSpec.js
+8 -5
View File
@@ -959,9 +959,7 @@ describe('$aria', function() {
function createHTML(type) {
var html = '<' + type + '>';
if (type === 'INPUT' || 'TYPE' === 'A') {
return html;
}
if (type === 'INPUT' || 'TYPE' === 'A') return html;
return html + '</' + type + '>';
}
@@ -975,10 +973,15 @@ describe('$aria', function() {
var interactiveElement = element.find(elementType);
// Use browserTrigger because it supports event bubbling
// 13 Enter
browserTrigger(interactiveElement, 'keydown', {cancelable: true, bubbles: true, keyCode: 13});
browserTrigger(interactiveElement, 'keydown', {cancelable: true, bubbles: true, keyCode: 32});
expect(clickEvents).toEqual([elementType.toLowerCase() + '(false)']);
expect(clickEvents).toEqual([elementType.toLowerCase() + '(false)', elementType.toLowerCase() + '(false)']);
clickEvents = [];
// 32 Space
browserTrigger(interactiveElement, 'keydown', {cancelable: true, bubbles: true, keyCode: 32});
expect(clickEvents).toEqual([elementType.toLowerCase() + '(false)']);
}
);