From 190bc1d52b046f6a9654451f5d1dbd6f0a925b29 Mon Sep 17 00:00:00 2001 From: Martin Staffa Date: Mon, 3 Sep 2018 09:32:08 +0200 Subject: [PATCH] fixup! fix(ngAria.ngClick): restrict preventDefault on space / enter to non-interactive elements --- test/ngAria/ariaSpec.js | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/test/ngAria/ariaSpec.js b/test/ngAria/ariaSpec.js index 36f785e82..fb20f610b 100644 --- a/test/ngAria/ariaSpec.js +++ b/test/ngAria/ariaSpec.js @@ -959,9 +959,7 @@ describe('$aria', function() { function createHTML(type) { var html = '<' + type + '>'; - if (type === 'INPUT' || 'TYPE' === 'A') { - return html; - } + if (type === 'INPUT' || 'TYPE' === 'A') return html; return html + ''; } @@ -975,10 +973,15 @@ describe('$aria', function() { var interactiveElement = element.find(elementType); // Use browserTrigger because it supports event bubbling + // 13 Enter browserTrigger(interactiveElement, 'keydown', {cancelable: true, bubbles: true, keyCode: 13}); - browserTrigger(interactiveElement, 'keydown', {cancelable: true, bubbles: true, keyCode: 32}); + expect(clickEvents).toEqual([elementType.toLowerCase() + '(false)']); - expect(clickEvents).toEqual([elementType.toLowerCase() + '(false)', elementType.toLowerCase() + '(false)']); + clickEvents = []; + + // 32 Space + browserTrigger(interactiveElement, 'keydown', {cancelable: true, bubbles: true, keyCode: 32}); + expect(clickEvents).toEqual([elementType.toLowerCase() + '(false)']); } );