Adjust last animation change to fix test #45

2018-11-17T06:47:43+08:00

phazei commented

2018-11-17 06:47:43 +08:00

(Migrated from github.com)

Was getting error:

Chrome 70.0.3538 (Mac OS X 10.14.0) $uibModal option by option openedClass should not add the modal-open class if modal is closed before animation FAILED

Tried to debug and see why the test was failing. Looking at the code just led to not knowing how the test ever even could pass since modal.close when called immediately after open, always checks the $modalStack before the new modalInstance is even added to it. Regardless, moved that part of the backdrop close listener outside of the postDigest call.

Was getting error: > Chrome 70.0.3538 (Mac OS X 10.14.0) $uibModal option by option openedClass should not add the modal-open class if modal is closed before animation FAILED Tried to debug and see why the test was failing. Looking at the code just led to not knowing how the test ever even could pass since `modal.close` when called immediately after open, always checks the $modalStack before the new modalInstance is even added to it. Regardless, moved that part of the backdrop close listener outside of the postDigest call.

phazei commented

2018-11-17 06:51:37 +08:00

(Migrated from github.com)

wrong branch

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: invisi/ui-bootstrap4#45