invisi/ui-bootstrap4
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases 8 Wiki Activity

Fixes carousel in BS4 by applying correct transition classes #4

Merged
wcoppens merged 1 commits from fix-carousel into master 2017-12-08 21:07:17 +08:00
Conversation 1 Commits 1 Files Changed 1
+7 -7
wcoppens commented 2017-12-08 20:56:40 +08:00 (Migrated from github.com)
Copy Link
Copy Source

This change fixes the use of carousel classes while transitioning and fixes the global class usage for a carousel.

e.g. .item becomes .carousel-item
and e.g. .next .prev, .left, right becomes .carousel-item-{next, prev, left, right}

This change fixes the use of carousel classes while transitioning and fixes the global class usage for a carousel. e.g. `.item` becomes `.carousel-item` and e.g. `.next` `.prev`, `.left`, `right` becomes `.carousel-item-{next, prev, left, right}`
Morgul (Migrated from github.com) approved these changes 2017-12-08 21:07:08 +08:00
Morgul (Migrated from github.com) left a comment
Copy Link
Copy Source

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No Reviewers
Morgul
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
needs investigation
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ubunteroz (Surya Handika Putratama)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: invisi/ui-bootstrap4#4
Delete Branch "fix-carousel"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?