invisi/ui-bootstrap4
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases 8 Wiki Activity

Fixed test carousel that did fail #30

Merged
haricot merged 1 commits from patch-3 into master 2018-07-02 09:28:58 +08:00
Conversation 0 Commits 1 Files Changed 1
-18
haricot commented 2018-07-02 07:40:00 +08:00 (Migrated from github.com)
Copy Link
Copy Source

I think this test is no longer necessary : should disable next button when last slide is active and noWrap is truthy
The class disabled no longer add to a.carousel-control-prev in bootstrap4

src/carousel/test/carousel.spec.js:183:54)
Executed 359 of 1332 (1 FAILED) (0 secs / 4.734 secs)

I think this test is no longer necessary : should disable next button when last slide is active and noWrap is truthy The class disabled no longer add to a.carousel-control-prev in bootstrap4 src/carousel/test/carousel.spec.js:183:54) Executed 359 of 1332 (1 FAILED) (0 secs / 4.734 secs)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
needs investigation
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ubunteroz (Surya Handika Putratama)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: invisi/ui-bootstrap4#30
Delete Branch "patch-3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?