docs(CHANGELOG): update with 1.7.7 release notes

Previously, in the required validator, we would read the required setting directly
from attr.required, where it is set by ngRequired.

However, when the control is inside ngRepeat, ngRequired sets it only after a another digest has
passed, which means the initial validation run of ngModel does not include the correct required
setting. (Before commit 0637a2124c this would not have been a problem,
as every observed value change triggered a validation).

We now use the initially parsed value from ngRequired in the validator.

Fixes #16814
Closes #16820

CHANGELOG.md

@@ -1,3 +1,13 @@
+<a name="1.7.7"></a>
+# 1.7.7 kingly-exiting (2019-02-04)
+
+## Bug Fixes
+- **ngRequired:** set error correctly when inside ngRepeat and false by default
+  ([5ad4f5](https://github.com/angular/angular.js/commit/5ad4f5562c37b1cb575e3e5fddd96e9dd10408e2),
+  [#16814](https://github.com/angular/angular.js/issues/16814),
+  [#16820](https://github.com/angular/angular.js/issues/16820))
+
+
 <a name="1.7.6"></a>
 # 1.7.6 gravity-manipulation (2019-01-17)
 

RELEASE.md

@@ -0,0 +1,98 @@
+# AngularJS Release instructions
+
+
+## Compare the list of commits between stable and unstable
+
+There is a script - compare-master-to-stable.js - that helps with this.
+We just want to make sure that good commits (low risk fixes + docs fixes) got cherry-picked into stable branch and nothing interesting got merged only into stable branch.
+
+
+## Pick a release name (for this version)
+
+A super-heroic power (adverb-verb phrase).
+
+
+## Generate release notes
+
+Example Commit: https://github.com/angular/angular.js/commit/7ab5098c14ee4f195dbfe2681e402fe2dfeacd78
+
+1) Run
+
+```bash
+node_modules/.bin/changez -o changes.md -v <new version> <base branch>
+```
+
+2) Review the generated file and manually fix typos, group and reorder stuff if needed.
+3) Move the content into CHANGELOG.md add release code-names to headers.
+4) Push the changes to your private github repo and review.
+5) cherry-pick the release notes commit to the appropriate branches.
+
+
+## Pick a commit to release (for this version)
+
+Usually this will be the commit containing the release notes, but it may also be in the past.
+
+
+## Run "release" script
+
+  ```bash
+  scripts/jenkins/release.sh --git-push-dryrun=false --commit-sha=8822a4f --version-number=1.7.6 --version-name=gravity-manipulation
+  ```
+
+  1) The SHA is of the commit to release (could be in the past).
+
+  2) The version number and code-name that should be released, not the next version number (e.g. to release 1.2.12 you enter 1.2.12 as release version and the code-name that was picked for 1.2.12, cauliflower-eradication).
+
+  3) You will need to have write access to all the AngularJS github dist repositories and publish rights for the AngularJS packages on npm.
+
+
+## Update GitHub milestones
+
+1) Create the next milestone if it doesn't exist yet-giving ita due date.
+2) Move all open issues and PRs for the current milestone to the next milestone<br>
+  You can do this by filtering the current milestone, selecting via checklist, and moving to the next milestone within the GH issues page.
+
+3) Close the current milestone click the milestones tab and close from there.
+4) Create a new holding milestone for the release after next-but don't give it a due date otherwise that will mess up the dashboard.
+
+
+## Push build artifacts to CDN
+
+Google CDNs are fed with data from google3 every day at 11:15am PT it takes only few minutes for the import to propagate).
+If we want to make our files available, we need submit our CLs before this time on the day of the release.
+
+
+## Don't update the package.json (branchVersion) until the CDN has updated
+
+This is the version used to compute what version to link to in the CDN. If you update this too early then the CDN lookup fails and you end up with 'null, for the version, which breaks the docs.
+
+
+## Verify angularjs.org download modal has latest version (updates via Travis job)
+
+The versions in the modal are updated (based on the versions available on CDN) as part of the Travis deploy stage: https://github.com/angular/angularjs.org/blob/a4d25c5abcd39e8ce19d31cb1c78073d13c4c974/.travis.yml#L26
+(You may need to explicitly trigger the Travis job. e.g. re-running the last job.)
+
+
+## Announce the release (via official Google accounts)
+
+Double check that angularjs.org is up to date with the new release version before sharing.
+
+1) Collect a list of contributors
+
+use: `git log --format='%aN' v1.2.12..v1.2.13 | sort -u`
+
+2) Write a blog post (for minor releases, not patch releases) and publish it with the "release" tag
+3) Post on twitter as yourself (tweet from your heart; there is no template for this), retweet as @AngularJS
+
+
+## Party!
+
+
+## Major Release Tasks
+
+1) Update angularjs.org to use the latest branch.
+2) Write up a migration document.
+3) Create a new git branch for the version that has been released (e.g. 1.8.x).
+4) Check that the build and release scripts still work.
+5) Update the dist-tag of the old branch, see https://github.com/angular/angular.js/pull/12722.
+6) Write a blog post.

src/Angular.js

@@ -396,8 +396,8 @@ function extend(dst) {
 * sinceVersion="1.6.5"
 * This function is deprecated, but will not be removed in the 1.x lifecycle.
 * There are edge cases (see {@link angular.merge#known-issues known issues}) that are not
-* supported by this function. We suggest
-* using [lodash's merge()](https://lodash.com/docs/4.17.4#merge) instead.
+* supported by this function. We suggest using another, similar library for all-purpose merging,
+* such as [lodash's merge()](https://lodash.com/docs/4.17.4#merge).
 *
 * @knownIssue
 * This is a list of (known) object types that are not handled correctly by this function:
@@ -406,6 +406,8 @@ function extend(dst) {
 * - [`CanvasGradient`](https://developer.mozilla.org/docs/Web/API/CanvasGradient)
 * - AngularJS {@link $rootScope.Scope scopes};
 *
+* `angular.merge` also does not support merging objects with circular references.
+*
 * @param {Object} dst Destination object.
 * @param {...Object} src Source object(s).
 * @returns {Object} Reference to `dst`.
@@ -783,7 +785,9 @@ function arrayRemove(array, value) {
  * @kind function
  *
  * @description
- * Creates a deep copy of `source`, which should be an object or an array.
+ * Creates a deep copy of `source`, which should be an object or an array. This functions is used
+ * internally, mostly in the change-detection code. It is not intended as an all-purpose copy
+ * function, and has several limitations (see below).
  *
  * * If no destination is supplied, a copy of the object or array is created.
  * * If a destination is provided, all of its elements (for arrays) or properties (for objects)
@@ -798,6 +802,25 @@ function arrayRemove(array, value) {
  *   and on `destination`) will be ignored.
  * </div>
  *
+ * <div class="alert alert-warning">
+ *   `angular.copy` does not check if destination and source are of the same type. It's the
+ *   developer's responsibility to make sure they are compatible.
+ * </div>
+ *
+ * @knownIssue
+ * This is a non-exhaustive list of object types / features that are not handled correctly by
+ * `angular.copy`. Note that since this functions is used by the change detection code, this
+ * means binding or watching objects of these types (or that include these types) might not work
+ * correctly.
+ * - [`File`](https://developer.mozilla.org/docs/Web/API/File)
+ * - [`Map`](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Map)
+ * - [`ImageData`](https://developer.mozilla.org/docs/Web/API/ImageData)
+ * - [`MediaStream`](https://developer.mozilla.org/docs/Web/API/MediaStream)
+ * - [`Set`](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Set)
+ * - [`WeakMap`](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/WeakMap)
+ * - ['getter'](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/get)/
+ *   [`setter`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/set)`
+ *
  * @param {*} source The source that will be used to make a copy. Can be any type, including
  *     primitives, `null`, and `undefined`.
  * @param {(Object|Array)=} destination Destination into which the source is copied. If provided,

src/ng/directive/attrs.js

@@ -181,7 +181,6 @@
       </file>
     </example>
  *
- * @element INPUT
  * @param {expression} ngDisabled If the {@link guide/expression expression} is truthy,
  *     then the `disabled` attribute will be set on the element
  */

src/ng/directive/input.js

@@ -909,8 +909,10 @@ var inputType = {
    *
    * <div class="alert alert-warning">
    * **Note:** `input[email]` uses a regex to validate email addresses that is derived from the regex
-   * used in Chromium. If you need stricter validation (e.g. requiring a top-level domain), you can
-   * use `ng-pattern` or modify the built-in validators (see the {@link guide/forms Forms guide})
+   * used in Chromium, which may not fulfill your app's requirements.
+   * If you need stricter (e.g. requiring a top-level domain), or more relaxed validation
+   * (e.g. allowing IPv6 address literals) you can use `ng-pattern` or
+   * modify the built-in validators (see the {@link guide/forms Forms guide}).
    * </div>
    *
    * @param {string} ngModel Assignable AngularJS expression to data-bind to.

src/ng/directive/validators.js

@@ -68,17 +68,17 @@ var requiredDirective = ['$parse', function($parse) {
     require: '?ngModel',
     link: function(scope, elm, attr, ctrl) {
       if (!ctrl) return;
-      var oldVal = attr.required || $parse(attr.ngRequired)(scope);
+      var value = attr.required || $parse(attr.ngRequired)(scope);
 
       attr.required = true; // force truthy in case we are on non input element
 
       ctrl.$validators.required = function(modelValue, viewValue) {
-        return !attr.required || !ctrl.$isEmpty(viewValue);
+        return !value || !ctrl.$isEmpty(viewValue);
       };
 
-      attr.$observe('required', function(val) {
-        if (oldVal !== val) {
-          oldVal = val;
+      attr.$observe('required', function(newVal) {
+        if (value !== newVal) {
+          value = newVal;
           ctrl.$validate();
         }
       });

src/ngParseExt/module.js

@@ -6,6 +6,7 @@
  * @ngdoc module
  * @name ngParseExt
  * @packageName angular-parse-ext
+ *
  * @description
  *
  * The `ngParseExt` module provides functionality to allow Unicode characters in
@@ -15,6 +16,11 @@
  * to be used as an identifier in an AngularJS expression. ES6 delegates some of the identifier
  * rules definition to Unicode, this module uses ES6 and Unicode 8.0 identifiers convention.
  *
+ * <div class="alert alert-warning">
+ * You cannot use Unicode characters for variable names in the {@link ngRepeat} or {@link ngOptions}
+ * expressions (e.g. `ng-repeat="f in поля"`), because even with `ngParseExt` included, these
+ * special expressions are not parsed by the {@link $parse} service.
+ * </div>
  */
 
 /* global angularParseExtModule: true,

test/ng/directive/validatorsSpec.js

@@ -730,5 +730,19 @@ describe('validators', function() {
 
       expect(helper.validationCounter.required).toBe(1);
     });
+
+    it('should validate once when inside ngRepeat, and set the "required" error when ngRequired is false by default', function() {
+      $rootScope.isRequired = false;
+      $rootScope.refs = {};
+
+      var elm = helper.compileInput(
+        '<div ng-repeat="input in [0]">' +
+          '<input type="text" ng-ref="refs.input" ng-ref-read="ngModel" ng-model="value" ng-required="isRequired" validation-spy="required" />' +
+        '</div>');
+
+      expect(helper.validationCounter.required).toBe(1);
+      expect($rootScope.refs.input.$error.required).toBeUndefined();
+    });
+
   });
 });