invisi/angular.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Wiki Activity

refactor(ngModelSpec): use valueFn over curry

Browse Source 
Refactor ngModelSpec to use internal helper function `valueFn`.
Use instead of multiple-defining a function called `curry`.

PR (#15231)

Addresses a quick change mentioned in PR 15208 from Issue #14734
This commit is contained in:
BobChao87
2016-10-09 11:07:08 -07:00
committed by Martin Staffa
parent 39a3b58ed2
commit faf0c3e4c1
1 changed files with 7 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/ng/directive/ngModelSpec.js
+7 -19
View File
@@ -827,21 +827,15 @@ describe('ngModel', function() {
it('should only validate to true if all validations are true', function() {
var curry = function(v) {
return function() {
return v;
};
};
ctrl.$modelValue = undefined;
ctrl.$validators.a = curry(true);
ctrl.$validators.b = curry(true);
ctrl.$validators.c = curry(false);
ctrl.$validators.a = valueFn(true);
ctrl.$validators.b = valueFn(true);
ctrl.$validators.c = valueFn(false);
ctrl.$validate();
expect(ctrl.$valid).toBe(false);
ctrl.$validators.c = curry(true);
ctrl.$validators.c = valueFn(true);
ctrl.$validate();
expect(ctrl.$valid).toBe(true);
@@ -875,16 +869,10 @@ describe('ngModel', function() {
it('should register invalid validations on the $error object', function() {
var curry = function(v) {
return function() {
return v;
};
};
ctrl.$modelValue = undefined;
ctrl.$validators.unique = curry(false);
ctrl.$validators.tooLong = curry(false);
ctrl.$validators.notNumeric = curry(true);
ctrl.$validators.unique = valueFn(false);
ctrl.$validators.tooLong = valueFn(false);
ctrl.$validators.notNumeric = valueFn(true);
ctrl.$validate();