invisi/angular.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Wiki Activity

revert:fix(input): ensure that hidden input values are correct after history.back

Browse Source 
This reverts commit 298f8c4d13.
There was a regression in angular-material that relied upon the input directive
having `link.pre` property.
This commit is contained in:
Peter Bacon Darwin
2016-10-11 13:28:56 +01:00
parent 8d394de91f
commit ec83b04df1
3 changed files with 6 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ng/directive/input.js
+6 -9
View File
@@ -2002,16 +2002,13 @@ var inputDirective = ['$browser', '$sniffer', '$filter', '$parse',
return {
restrict: 'E',
require: ['?ngModel'],
compile: function(tElement, tAttr) {
if (lowercase(tAttr.type) === 'hidden') tAttr.$set('autocomplete', 'off');
return {
pre: function(scope, element, attr, ctrls) {
if (ctrls[0]) {
(inputType[lowercase(attr.type)] || inputType.text)(scope, element, attr, ctrls[0], $sniffer,
$browser, $filter, $parse);
}
link: {
pre: function(scope, element, attr, ctrls) {
if (ctrls[0]) {
(inputType[lowercase(attr.type)] || inputType.text)(scope, element, attr, ctrls[0], $sniffer,
$browser, $filter, $parse);
}
};
}
}
};
}];
test/e2e/fixtures/input-hidden/index.html
-10
View File
@@ -1,10 +0,0 @@
<!DOCTYPE html>
<html ng-app>
<body>
<form>
<input type="hidden" value="{{value}}" />
<button ng-click="value = '{{ 7 * 6 }}'">Click me</button>
</form>
<script src="angular.js"></script>
</body>
</html>
test/e2e/tests/input-hidden.spec.js
-17
View File
@@ -1,17 +0,0 @@
'use strict';
describe('hidden thingy', function() {
it('should pass', function() {
loadFixture('input-hidden');
expect(element(by.css('input')).getAttribute('value')).toEqual('');
element(by.css('button')).click();
expect(element(by.css('input')).getAttribute('value')).toEqual('{{ 7 * 6 }}');
loadFixture('sample');
browser.driver.executeScript('history.back()');
var expectedValue = browser.params.browser === 'safari' ? '{{ 7 * 6 }}' : '';
expect(element(by.css('input')).getAttribute('value')).toEqual(expectedValue);
});
});