fix($rootScope): $watchCollection should handle NaN in objects
This fixes a potential infinite digest in $watchCollection when one of the values is NaN. This was previously fixed for arrays, but needs to be handled for objects as well. Closes #7930
This commit is contained in:
+5
-3
@@ -443,7 +443,7 @@ function $RootScopeProvider(){
|
||||
|
||||
function $watchCollectionWatch() {
|
||||
newValue = objGetter(self);
|
||||
var newLength, key;
|
||||
var newLength, key, bothNaN;
|
||||
|
||||
if (!isObject(newValue)) { // if primitive
|
||||
if (oldValue !== newValue) {
|
||||
@@ -467,7 +467,7 @@ function $RootScopeProvider(){
|
||||
}
|
||||
// copy the items to oldValue and look for changes.
|
||||
for (var i = 0; i < newLength; i++) {
|
||||
var bothNaN = (oldValue[i] !== oldValue[i]) &&
|
||||
bothNaN = (oldValue[i] !== oldValue[i]) &&
|
||||
(newValue[i] !== newValue[i]);
|
||||
if (!bothNaN && (oldValue[i] !== newValue[i])) {
|
||||
changeDetected++;
|
||||
@@ -487,7 +487,9 @@ function $RootScopeProvider(){
|
||||
if (newValue.hasOwnProperty(key)) {
|
||||
newLength++;
|
||||
if (oldValue.hasOwnProperty(key)) {
|
||||
if (oldValue[key] !== newValue[key]) {
|
||||
bothNaN = (oldValue[key] !== oldValue[key]) &&
|
||||
(newValue[key] !== newValue[key]);
|
||||
if (!bothNaN && (oldValue[key] !== newValue[key])) {
|
||||
changeDetected++;
|
||||
oldValue[key] = newValue[key];
|
||||
}
|
||||
|
||||
@@ -698,6 +698,14 @@ describe('Scope', function() {
|
||||
$rootScope.$digest();
|
||||
expect(log.empty()).toEqual([{newVal: {b: {}, c: 'B'}, oldVal: {a: [], b: {}, c: 'B'}}]);
|
||||
});
|
||||
|
||||
it('should not infinitely digest when current value is NaN', function() {
|
||||
$rootScope.obj = {a: NaN};
|
||||
expect(function() {
|
||||
$rootScope.$digest();
|
||||
}).not.toThrow();
|
||||
});
|
||||
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
Reference in New Issue
Block a user