invisi/ui-bootstrap4
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases 8 Wiki Activity

Fix keyboard navigation in dropdown #68

Merged
kerryj89 merged 1 commits from patch-1 into master 2022-05-06 21:47:28 +08:00
Conversation 2 Commits 1 Files Changed 1
+2 -2
kerryj89 commented 2022-05-06 08:24:40 +08:00 (Migrated from github.com)
Copy Link
Copy Source

The previous change assumed jQuery was in use (angular.element uses jQuery Lite by default which does NOT support class names with .find() - https://docs.angularjs.org/api/ng/function/angular.element). This change works without wrapping angular.element() around the selectors but I did it to keep it AngularJS-ish (don't really know if there are benefits to making it into a jqLite or jQuery object again).

The previous change assumed jQuery was in use (angular.element uses jQuery Lite by default which does NOT support class names with .find() - https://docs.angularjs.org/api/ng/function/angular.element). This change works without wrapping angular.element() around the selectors but I did it to keep it AngularJS-ish (don't really know if there are benefits to making it into a jqLite or jQuery object again).
kerryj89 commented 2022-05-06 08:25:07 +08:00 (Migrated from github.com)
Copy Link
Copy Source

https://github.com/Morgul/ui-bootstrap4/issues/67

https://github.com/Morgul/ui-bootstrap4/issues/67
Morgul commented 2022-05-06 21:47:16 +08:00 (Migrated from github.com)
Copy Link
Copy Source

That seems like a reasonable fix.

I'll try to remind myself how to do a release this weekend. (Haven't even looked at this project in years. 😅)

That seems like a reasonable fix. I'll try to remind myself how to do a release this weekend. (Haven't even looked at this project in years. 😅)
😆 1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
needs investigation
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ubunteroz (Surya Handika Putratama)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: invisi/ui-bootstrap4#68
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?