invisi/ui-bootstrap4
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases 8 Wiki Activity

Modal: Add support for .modal-dialog-scrollable #61

New Issue
Closed
opened 2020-01-21 22:00:47 +08:00 by modmatrix · 3 comments
modmatrix commented 2020-01-21 22:00:47 +08:00 (Migrated from github.com)
Copy Link
Copy Source

It'd be nice (and pretty easy) to add support for the .modal-dialog-scrollable class:

https://getbootstrap.com/docs/4.4/components/modal/#scrolling-long-content

Right now, it isn't possible to use this feature without resorting to hacks.

(I might submit a pull request for this when I have time – this issue is just a reminder for myself, or someone else, to do that.)

It'd be nice (and pretty easy) to add support for the .modal-dialog-scrollable class: https://getbootstrap.com/docs/4.4/components/modal/#scrolling-long-content Right now, it isn't possible to use this feature without resorting to hacks. (I might submit a pull request for this when I have time – this issue is just a reminder for myself, or someone else, to do that.)
👍 1
videk1 commented 2020-06-15 15:47:48 +08:00 (Migrated from github.com)
Copy Link
Copy Source

Please add support for this. Much needed!

Please add support for this. Much needed!
Morgul commented 2020-06-26 03:05:49 +08:00 (Migrated from github.com)
Copy Link
Copy Source

I would be fine if someone wants to add that. I'll gladly review the code and merge it in. I, however, am doing active development on this project, so this will have to come from the community.

I would be fine if someone wants to add that. I'll gladly review the code and merge it in. I, however, am doing active development on this project, so this will have to come from the community.
doublesharp commented 2021-04-30 01:25:05 +08:00 (Migrated from github.com)
Copy Link
Copy Source

@Morgul - this tripped me up because in the 3.0.7 version the dist/ui-bootstrap.js version is still at 3.0.6. The 3.0.7 ones have the version in the filename, but it was unexpected for them to not match, so by including the file without the version in the name this functionality was missing.

@Morgul - this tripped me up because in the 3.0.7 version the dist/ui-bootstrap.js version is still at 3.0.6. The 3.0.7 ones have the version in the filename, but it was unexpected for them to not match, so by including the file without the version in the name this functionality was missing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
needs investigation
question
wontfix
No Label bug good first issue help wanted
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ubunteroz (Surya Handika Putratama)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: invisi/ui-bootstrap4#61
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?