diff --git a/pkg/gotenberg/attrs.go b/pkg/gotenberg/attrs.go index e5e1de5..a269a9b 100644 --- a/pkg/gotenberg/attrs.go +++ b/pkg/gotenberg/attrs.go @@ -2,6 +2,7 @@ package gotenberg import ( "net/url" + "slices" ) // maxAttrRunes bounds the length of a string span attribute to keep payload @@ -45,10 +46,8 @@ func RedactURL(raw string) string { // a span attribute or metric dimension bounded even when an upstream tool // introduces a new enum value. func MapEnum(value string, allowed ...string) string { - for _, candidate := range allowed { - if value == candidate { - return value - } + if slices.Contains(allowed, value) { + return value } return "other" } diff --git a/pkg/modules/chromium/chromium.go b/pkg/modules/chromium/chromium.go index 06565c3..87b0207 100644 --- a/pkg/modules/chromium/chromium.go +++ b/pkg/modules/chromium/chromium.go @@ -1029,8 +1029,8 @@ func conversionInputAttrs(ctx context.Context, url string) []attribute.KeyValue attrs = append(attrs, attribute.Int("gotenberg.conversion.input.files.count", apiCtx.FileCount())) } - if strings.HasPrefix(url, "file://") { - if info, err := os.Stat(strings.TrimPrefix(url, "file://")); err == nil { + if after, ok := strings.CutPrefix(url, "file://"); ok { + if info, err := os.Stat(after); err == nil { attrs = append(attrs, attribute.Int64("gotenberg.conversion.input.html.bytes", info.Size())) } } diff --git a/pkg/modules/chromium/network_aggregate_test.go b/pkg/modules/chromium/network_aggregate_test.go index 67db6dc..bfa49b9 100644 --- a/pkg/modules/chromium/network_aggregate_test.go +++ b/pkg/modules/chromium/network_aggregate_test.go @@ -66,7 +66,7 @@ func TestNetworkAggregate_Snapshot(t *testing.T) { func TestNetworkAggregate_OriginCap(t *testing.T) { a := newNetworkAggregate() - for i := 0; i < maxTrackedOrigins+50; i++ { + for i := range maxTrackedOrigins + 50 { a.onResponseReceived(&network.EventResponseReceived{ RequestID: network.RequestID(fmt.Sprintf("r%d", i)), Response: &network.Response{URL: fmt.Sprintf("https://host%d.example.com/x", i)}, @@ -80,7 +80,7 @@ func TestNetworkAggregate_OriginCap(t *testing.T) { func TestNetworkAggregate_ConcurrentSafe(t *testing.T) { a := newNetworkAggregate() var wg sync.WaitGroup - for i := 0; i < 100; i++ { + for i := range 100 { wg.Add(1) go func(i int) { defer wg.Done() diff --git a/pkg/modules/pdfengines/fallback_test.go b/pkg/modules/pdfengines/fallback_test.go index 3d9ace2..40fbd70 100644 --- a/pkg/modules/pdfengines/fallback_test.go +++ b/pkg/modules/pdfengines/fallback_test.go @@ -45,7 +45,6 @@ func TestRunWithFallback_FirstSucceeds(t *testing.T) { calls++ return "ok", nil }, wrapTest) - if err != nil { t.Fatalf("unexpected error: %v", err) } @@ -85,7 +84,6 @@ func TestRunWithFallback_SecondSucceeds(t *testing.T) { } return "ok", nil }, wrapTest) - if err != nil { t.Fatalf("unexpected error: %v", err) }