From 28c0497524279ce489c29001c3bda9a563d71679 Mon Sep 17 00:00:00 2001 From: Juan Manuel Palacios Date: Fri, 23 May 2014 00:47:32 -0430 Subject: [PATCH] docs(tutorial): match html from angular-phonecat in step 7 instructions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Place phoneId binding in a proper HTML node The code where the phoneId binding in the phone-detail.html template is first explained in step 7 of the tutorial doesn't make it a child of a proper HTML node, which makes the end-to-end test against the view (also introduced in step 7) fail. The test acquires the binding right from the view (by.binding('phoneId')), and apparently this operation fails when the binding is not a child of an HTML node, and therefore the entire test also fails. As soon as the binding is placed inside a tag pair, the binding is found and the test passes. The code on github for step 7 has it right, the binding is within the span tags, but in the documentation I'm patching here the span's are missing. ☆.。.：*・゜☆ MERCI ☆.。.：*・゜☆ --- docs/content/tutorial/step_07.ngdoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/content/tutorial/step_07.ngdoc b/docs/content/tutorial/step_07.ngdoc index f5bdf88b6..c1e4e1766 100644 --- a/docs/content/tutorial/step_07.ngdoc +++ b/docs/content/tutorial/step_07.ngdoc @@ -185,7 +185,7 @@ We also added a placeholder template for the phone details view: __`app/partials/phone-detail.html`:__ ```html -TBD: detail view for {{phoneId}} +TBD: detail view for {{phoneId}} ``` Note how we are using the `phoneId` expression which will be defined in the `PhoneDetailCtrl` controller.